masm - Comparing negatives and accumulating in Assembly -

-

i'm having trouble figuring out how compare inputs negatives in masm. positive input integers, use cmp doesn't seem working me in program.

i'm missing 1 or 2 lines in calcloop think, because program ends right after user inputs positive value, after inputting negative values. program should add , average values entered, 1 should negatives between [-100,-1]. when input -100 or -1, these should allowed not.

any appreciated i'm still trying figure out of basics of assembly. thanks!

code:

title program3     (program3.asm)  include irvine32.inc  lengthlimit = 20  .data  intro byte "program 3: accumulator  ", 13,10             byte "what name: ",0  prompt1 byte "oh hello, ",0  enternumprompt byte "enter numbers between -100 , -1.",13,10                 byte "enter non-negative now: ",13,10,0  prompt2 byte "enter #: ",0 prompt3 byte "okay, ",0 prompt4 byte " numbers.",0  addprompt byte "the sum of numbers entered is, ",0 roundprompt byte "the rounded average is: "  errorprompt byte "whoops! numbers less or equal -1, please",13,10,0  nameinputlimit byte 24 dup(0)  seeya byte "thanks using accumulator, " seeyaname byte "!"   numentered dword ? amountofnums dword ? result dword ? sumresult dword ? avgresult dword ?  .code main proc  mov edx, offset intro call crlf call writestring mov edx, offset nameinputlimit mov ecx, sizeof nameinputlimit call readstring   mov edx, offset prompt1 call writestring mov edx, offset nameinputlimit call writestring call crlf  mov edx, 0000000h  mov edx, offset enternumprompt call writestring call crlf call crlf  getloop:  mov edx, offset prompt2 call writestring call readint cmp eax, -100  jg errorloop  cmp eax, -1 jl complete  jmp calcloop  errorloop:  mov edx, offset errorprompt call writestring jmp getloop  calcloop: ;missing line or 2 here think  mov numentered, eax mov eax, result add eax, numentered mov result, eax  jmp getloop  complete:  call crlf mov numentered, eax   goodbye:  mov edx, offset seeya call writestring  exit      ; (insert executable instructions here)  exit     main endp  ; (insert additional procedures here)  end main

your instructions correctly chosen, program flow needed fixing.

just clarity, these relevant comparison instructions.

jg  - greather than? (signed numbers e.g. -128 127) jl  - less than?     (signed numbers e.g. -128 127) ja  - above?         (unsigned numbers e.g. 0 255) jb  - below?         (unsigned numbers e.g. 0 255)

below fixed version of main loop:

... getloop: mov edx, offset prompt2 call writestring call readint ; !!!todo!!! add abort condition jumping 'complete' here! cmp eax, -100 jl errorloop         ; 'jg errorloop' - better goto error if less -100    cmp eax, -1 jg errorloop         ; 'jl complete' - error on value greater -1 add result, eax      ; more not necessary jmp getloop  errorloop:     mov edx, offset errorprompt call writestring jmp getloop

Comments

Post a Comment

Popular posts from this blog

Delphi XE2 Indy10 udp client-server interchange using SendBuffer-ReceiveBuffer -

-
i use delphi xe2 , indy10 udp protocol. can't receive server echo on client side if use receivebuffer method. got "socket error # 10040" although send small echo message server client. console application illustrate problem below. in advance. program project1; {$apptype console} {$r *.res} uses system.sysutils, idglobal, idbasecomponent, idcomponent, idsockethandle, idudpclient, idudpserver, idudpbase, idstack; type tudp_serv = class(tidudpserver) procedure udpsvudpread(athread: tidudplistenerthread; adata: tidbytes; abinding: tidsockethandle); end; var udpserver: tudp_serv; udpcl: tidudpclient; bsnd, brcv: tbytes; s: string; k: integer; //============================================================================== procedure tudp_serv.udpsvudpread(athread: tidudplistenerthread; adata: tidbytes; abinding: tidsockethandle); begin writeln(' server read: ' + tohex(adata, length(adata))); abinding sendto(peerip, peerport, adat...
Read more

Qt ActiveX WMI QAxBase::dynamicCallHelper: ItemIndex(int): No such property in -

-
i new windows programming. here goes code objiwbemlocator = new qaxobject("wbemscripting.swbemlocator"); objwmiservice = objiwbemlocator->querysubobject("connectserver(qstring&,qstring&)",qstring("."),qstring("root\\cimv2")); qaxobject* returnlist = objwmiservice->querysubobject("execquery(qstring&)", qstring("select * %1").arg(domain)); qaxobject* result = returnlist->querysubobject("itemindex(int)", 0); i getting error on runtime qt activex wmi qaxbase::dynamiccallhelper: itemindex(int): no such property in but itemindex method exists msdn says the itemindex method not work collections not contain swbemobjects, such swbemmethodset, swbemnamedvalueset, swbemprivilegeset, swbempropertyset, , swbemqualifierset. what selecting ? have tried iterating on collection ? plus need minimum windows vista itemindex method. hope helps
Read more

Enable autocomplete or intellisense in Atom editor for PHP -

-
i'm first time user of atom editor php code. atom can autocomplete built-in functions of php. possible make editor autocomplete custom function written in separate file? function.php <?php function printsomething() { echo "hello world"; } index.php <?php require_once "function.php"; printsomething(); // autocompleted atom editor while typing thanks in advance. there text file in %userprofile%.atom called snippets.cson. in there can add snippet. more this: http://flight-manual.atom.io/using-atom/sections/snippets/ but need think can use later on other files well. otherwise need copy , paste.
Read more